From 9dcf92649cc3bf4b5152545286ef3be74c196fa4 Mon Sep 17 00:00:00 2001 From: Yudai Fukushima <49578068+granddaifuku@users.noreply.github.com> Date: Thu, 4 Jan 2024 13:49:33 +0000 Subject: [PATCH] fix: metadata-collector listing lints when config documents include comma --- clippy_config/src/conf.rs | 2 +- clippy_config/src/metadata.rs | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/clippy_config/src/conf.rs b/clippy_config/src/conf.rs index f88ab9fe440f..5477d9b83a72 100644 --- a/clippy_config/src/conf.rs +++ b/clippy_config/src/conf.rs @@ -550,7 +550,7 @@ define_Conf! { /// Lint: PUB_UNDERSCORE_FIELDS /// /// Lint "public" fields in a struct that are prefixed with an underscore based on their - /// exported visibility; or whether they are marked as "pub". + /// exported visibility, or whether they are marked as "pub". (pub_underscore_fields_behavior: PubUnderscoreFieldsBehaviour = PubUnderscoreFieldsBehaviour::PublicallyExported), } diff --git a/clippy_config/src/metadata.rs b/clippy_config/src/metadata.rs index 2451fbc91e89..3ba2796e18d3 100644 --- a/clippy_config/src/metadata.rs +++ b/clippy_config/src/metadata.rs @@ -96,6 +96,9 @@ fn parse_config_field_doc(doc_comment: &str) -> Option<(Vec, String)> { doc_comment.make_ascii_lowercase(); let lints: Vec = doc_comment .split_off(DOC_START.len()) + .lines() + .next() + .unwrap() .split(", ") .map(str::to_string) .collect();