Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need more incrementality tests #15685

Open
Veykril opened this issue Sep 29, 2023 · 1 comment · Fixed by #15959
Open

We need more incrementality tests #15685

Veykril opened this issue Sep 29, 2023 · 1 comment · Fixed by #15959
Assignees
Labels
A-infra CI and workflow issues A-perf performance issues Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented Sep 29, 2023

We currently only have a very few for the defmap here
https://github.com/rust-lang/rust-analyzer/blob/87e2c310f9f1770aa09c1223ae4a5b7b8ce33360/crates/hir-def/src/nameres/tests/incremental.rs
and while def map incrementality is the most important one to get right we should also check for more things, like typechecking not being invalidated in expected cases etc

@Veykril Veykril added A-perf performance issues C-bug Category: bug A-infra CI and workflow issues labels Sep 29, 2023
@Veykril Veykril self-assigned this Nov 30, 2023
@bors bors closed this as completed in e91fdf7 Dec 4, 2023
@Veykril Veykril reopened this Oct 22, 2024
@Veykril
Copy link
Member Author

Veykril commented Oct 22, 2024

Re-opening this, we still lack a lot of tests for this on differeing levels, especially on bodies wrt to macros I'd say, #18264 is an important one for this

@Veykril Veykril added the Broken Window Bugs / technical debt to be addressed immediately label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra CI and workflow issues A-perf performance issues Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant