Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconstruct Kontrol's functionality related to minimization and merge node #908

Open
Stevengre opened this issue Dec 10, 2024 · 0 comments
Open

Reconstruct Kontrol's functionality related to minimization and merge node #908

Stevengre opened this issue Dec 10, 2024 · 0 comments
Assignees
@Stevengre
Labels
enhancement New feature or request

Comments

@Stevengre
Copy link
Contributor

Some codes related to minimize_proof and merging node are not correct, e.g.,

  • Doesn't support merging node functionality

kontrol/src/kontrol/foundry.py

Line 910 in eb61949

KCFGMinimizer(proof.kcfg).minimize()

  • Doesn't support merging node correctly (miss the hueristic for merging node)

kontrol/src/kontrol/foundry.py

Line 1119 in eb61949

apr_proof.minimize_kcfg(merge=options.merge)

@Stevengre Stevengre added the enhancement New feature or request label Dec 10, 2024
@Stevengre Stevengre self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stevengre Stevengre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stevengre