Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this actually work? I’m hopeful that it does #9

Closed
ghost opened this issue Jan 19, 2024 · 7 comments
Closed

Does this actually work? I’m hopeful that it does #9

ghost opened this issue Jan 19, 2024 · 7 comments

Comments

@ghost
Copy link

ghost commented Jan 19, 2024

Hello, I’m wondering if this allows me to use Quicklisp to download over https why hasn’t the quicklisp developer implement something similar?

anyways I’m going to start using this. Thanks

@bo-tato
Copy link
Collaborator

bo-tato commented Jan 19, 2024

see the discussion at quicklisp/quicklisp-client#167
basically this isn't completely portable as only 99% of systems have curl, not 100%. also certificate authorities can forge https certificates, it's better to verify signatures from the package developers and they're developing some signature verification scheme but don't really have time to work on it so it just stays how it is

@daninus14
Copy link

Is it possible to make a check if curl is available in the system? If it is, use curl for https, if it's not, then use the regular http way the way quicklisp does it. At least that way we would have a preferred https over http if it's available.

They may also accept a PR since it will not break anything while theydo the signature verification.

What do you think?

@daninus14
Copy link

Ok, it's not so complicated

(uiop:run-program "curlaiwdnjawn -V")

Will give an error, we just have to wrap it in a handler-case.

(uiop:run-program "curl -V")

This last version works, and it's the same for windows it looks like. So before any request, we can just check...

It's really not complicated

@daninus14
Copy link

On windows it could be it's curl --version https://farmwrangler.com/blog/how-to-check-if-curl-is-installed/

not running on windows so I don't know...

@rudolfochrist
Copy link
Owner

@daninus14
Sure. PRs are welcome.

@daninus14
Copy link

Ok, can you at least guide me as to where I have to make the change since it's your code base?

@rudolfochrist
Copy link
Owner

rudolfochrist commented Sep 23, 2024

@daninus14 let's take this discussion to its own issue. -> #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants