-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Tailwind CSS V2 Support #7
Comments
Pending on web-infra-dev/rslib#413 |
👀 Does this issue rely on web-infra-dev/rslib#413 to build this package itself? |
Yes, I'm going to check But there is another way to support Tailwind CSS V2. By publishing a different version of this plugin for Tailwind CSS V2. |
How about using |
Yeah, we should go this way. I just checked that Import Attributes is not supported in NodeJS 16 :)
|
### Summary Support Tailwind CSS v3.1 and Tailwind CSS v3.2. --- ### Details Since Tailwind CSS support using ESM configuration in V3.3, we need to use CJS configuration before that. As mentioned in #7 (comment), we use `readFile` + `require.resolve` to get the version of `tailwindcss/package.json`. - If `satisfies(version, ^3.3.0)`, we will generate ESM configuration to support both ESM and CJS. - Else, we generate CJS configuration. --- ### Test plan We setup two new entries in the testing matrix - tailwindcss v3.1.0 with Ubuntu - tailwindcss v3.1.0 with Windows As you can see, the test is failing at [0e05c6a](0e05c6a). And after the fix is landed in [e783415](e783415), the test for old tailwindcss is passing. --- ### Related links close: #18 - Tailwind CSS v3.3: - https://github.com/tailwindlabs/tailwindcss/releases/tag/v3.3.0 - tailwindlabs/tailwindcss#10785 - Tailwind CSS v3.2 - https://github.com/tailwindlabs/tailwindcss/releases/tag/v3.2.0 - Tailwind CSS v3.1 - https://github.com/tailwindlabs/tailwindcss/releases/tag/v3.1.0
Support using this plugin with both
tailwindcss@v3
andtailwindcss@v2
.The text was updated successfully, but these errors were encountered: