Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit for vendored zenoh-c pkg #59

Closed
clalancette opened this issue Nov 9, 2023 · 1 comment
Closed

Fix commit for vendored zenoh-c pkg #59

clalancette opened this issue Nov 9, 2023 · 1 comment
Assignees
@Yadunund

Comments

@clalancette
Copy link
Collaborator

We used to have zenoh-c pinned at 0.10-0-dev but since then switched to master. At some point we should pin a commit to always build against. If we really want to use the old protocol versions, this should also be possible with a diff patch we can apply to the Cargo.toml.in to clone the corresponding branch from upstream zenoh and not always use `master. See comment.
@Yadunund Yadunund mentioned this issue Dec 27, 2023
Merged
@clalancette
Copy link
Collaborator Author

This was fixed by #89, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yadunund Yadunund

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clalancette @Yadunund