From ac7ae53e7523a7bec57c90d461afa929ba77774d Mon Sep 17 00:00:00 2001 From: Sai Kishor Kothakota Date: Thu, 2 Jan 2025 21:56:10 +0100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Christoph Fröhlich --- include/realtime_tools/lock_free_queue.hpp | 4 ---- package.xml | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/realtime_tools/lock_free_queue.hpp b/include/realtime_tools/lock_free_queue.hpp index 7e438a23..8cecb5ec 100644 --- a/include/realtime_tools/lock_free_queue.hpp +++ b/include/realtime_tools/lock_free_queue.hpp @@ -201,8 +201,6 @@ class LockFreeQueueBase [[nodiscard]] std::enable_if_t, bool> bounded_push(const U & data) { if (!data_queue_.push(data)) { - // data_queue_.pop(); - // return data_queue_.push(data); T dummy; data_queue_.pop(dummy); return data_queue_.push(data); @@ -237,8 +235,6 @@ class LockFreeQueueBase [[nodiscard]] std::enable_if_t, bool> bounded_push(const U & data) { if (!data_queue_.bounded_push(data)) { - // data_queue_.pop(); - // return data_queue_.push(data); T dummy; data_queue_.pop(dummy); return data_queue_.bounded_push(data); diff --git a/package.xml b/package.xml index 3e179b6a..50829129 100644 --- a/package.xml +++ b/package.xml @@ -19,7 +19,7 @@ ament_cmake - libboost-dev + libboost-dev rclcpp rclcpp_action libcap-dev