From 0e8aefd9389e3c196a8357125d18444c7f5ed68d Mon Sep 17 00:00:00 2001 From: ronvanderheijden Date: Thu, 25 Apr 2024 20:50:17 +0200 Subject: [PATCH 1/5] Fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e2113e3..d57ec63 100644 --- a/README.md +++ b/README.md @@ -29,7 +29,7 @@ chmod 644 tmp/public.key ``` ## Example -I recommand to [read this](https://oauth2.thephpleague.com/authorization-server/auth-code-grant/) first. +I recommend to [read this](https://oauth2.thephpleague.com/authorization-server/auth-code-grant/) first. To enable OpenID Connect, follow these simple steps From ac8847c0c771c9bd771d9d5ef36abc917f9ab77c Mon Sep 17 00:00:00 2001 From: ronvanderheijden Date: Thu, 25 Apr 2024 20:54:43 +0200 Subject: [PATCH 2/5] Added declare strict types --- src/Laravel/DiscoveryController.php | 2 ++ src/Laravel/JwksController.php | 2 ++ src/Laravel/routes/web.php | 3 +++ 3 files changed, 7 insertions(+) diff --git a/src/Laravel/DiscoveryController.php b/src/Laravel/DiscoveryController.php index e6dd271..a69e387 100644 --- a/src/Laravel/DiscoveryController.php +++ b/src/Laravel/DiscoveryController.php @@ -1,5 +1,7 @@ name('openid.jwks'); } From d7c640d432097e9b0893ebfb20e2fb4cc310f6bc Mon Sep 17 00:00:00 2001 From: ronvanderheijden Date: Thu, 25 Apr 2024 20:55:16 +0200 Subject: [PATCH 3/5] Added trailing commas --- src/Laravel/config/openid.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Laravel/config/openid.php b/src/Laravel/config/openid.php index 0129888..be2da2f 100644 --- a/src/Laravel/config/openid.php +++ b/src/Laravel/config/openid.php @@ -59,5 +59,5 @@ * - /oauth/jwks */ 'jwks' => true, - ] + ], ]; From a7a6eeefaef7f21af86dad4009679df6725b6e71 Mon Sep 17 00:00:00 2001 From: ronvanderheijden Date: Thu, 25 Apr 2024 20:56:09 +0200 Subject: [PATCH 4/5] Decrease line sizes --- src/Laravel/routes/web.php | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/Laravel/routes/web.php b/src/Laravel/routes/web.php index 0a888b4..bb082e7 100644 --- a/src/Laravel/routes/web.php +++ b/src/Laravel/routes/web.php @@ -2,9 +2,16 @@ declare(strict_types=1); +use Illuminate\Support\Facades\Route; +use OpenIDConnect\Laravel\DiscoveryController; +use OpenIDConnect\Laravel\JwksController; + if (config('openid.routes.discovery', true)) { - Route::get('/oauth/jwks', \OpenIDConnect\Laravel\JwksController::class)->name('openid.jwks'); + Route::get('/oauth/jwks', JwksController::class) + ->name('openid.jwks'); } + if (config('openid.routes.jwks', true)) { - Route::get('/.well-known/openid-configuration', \OpenIDConnect\Laravel\DiscoveryController::class)->name('openid.discovery'); + Route::get('/.well-known/openid-configuration', DiscoveryController::class) + ->name('openid.discovery'); } From 4a2d722a0dafd3944aabddc023624f373e8c2e9a Mon Sep 17 00:00:00 2001 From: ronvanderheijden Date: Thu, 25 Apr 2024 20:57:59 +0200 Subject: [PATCH 5/5] Removed unused "use" --- src/Laravel/JwksController.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Laravel/JwksController.php b/src/Laravel/JwksController.php index 9871826..46ff700 100644 --- a/src/Laravel/JwksController.php +++ b/src/Laravel/JwksController.php @@ -4,7 +4,6 @@ namespace OpenIDConnect\Laravel; -use Illuminate\Config\Repository as Config; use Laravel\Passport\Passport; class JwksController