Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do the parameters in $attributes and prompts. yaml need to be concatenated with ' ' instead of: "," #99

Open
benzhangdragonplus opened this issue Jul 8, 2024 · 1 comment

Comments

@benzhangdragonplus
Copy link

file location:trainscripts/imagesliders/prompt_util.py
row 163-167:
copy_['target'] = att + ' ' + copy_['target']
copy_['positive'] = att + ' ' + copy_['positive']
copy_['neutral'] = att + ' ' + copy_['neutral']
copy_['unconditional'] = att + ' ' + copy_['unconditional']

Why do $attributes need to be concatenated with ' ' for all parameters?
Will this not be considered as the same set of prompt words as the following prompt words? Should ' ,' not be used for concatenation?

@rohitgandikota
Copy link
Owner

Hi, thanks for the question! I dont think we have looked into different ways to concatenate the attributes to the original prompts. This was a design choice to use ' ' instead of a ','

Please let us know if you have observed any significant performance improvements or changes when using a comma instead. Would be happy to integrate the change to the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants