Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wildcard * type variables #7451

Open
Tracked by #7106
smores56 opened this issue Jan 2, 2025 · 1 comment · Fixed by #7642
Open
Tracked by #7106

Remove wildcard * type variables #7451

smores56 opened this issue Jan 2, 2025 · 1 comment · Fixed by #7642
Labels
intermediate issue Likely good for someone who has completed a few other issues parsing Relates to the Parsing compiler stage type checking Relates to type checking compiler stage

Comments

@smores56
Copy link
Collaborator

smores56 commented Jan 2, 2025

It seems that the * type variable is more trouble than it's worth, and the confusion it causes to beginners and experienced Roc devs alike is cause for removal.

  • We'll need to replace all usages of * with vars in the *.roc builtins
  • We should continue to parse them, but add a deprecation warning
  • We can remove them from the rest of the compiler
@smores56 smores56 added parsing Relates to the Parsing compiler stage type checking Relates to type checking compiler stage intermediate issue Likely good for someone who has completed a few other issues labels Jan 2, 2025
@smores56 smores56 mentioned this issue Jan 3, 2025
6 tasks
@smores56
Copy link
Collaborator Author

smores56 commented Mar 1, 2025

This no longer exists in the new Zig-based parsing code, but needs to be propagated throughout our builtins when they are ported over to the new compiler.

@smores56 smores56 reopened this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intermediate issue Likely good for someone who has completed a few other issues parsing Relates to the Parsing compiler stage type checking Relates to type checking compiler stage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant