From e6080267f1c6e23084fdea9167f6c43a5a8f9999 Mon Sep 17 00:00:00 2001
From: Natan Yellin <aantn@users.noreply.github.com>
Date: Fri, 14 Jun 2024 11:35:25 +0300
Subject: [PATCH] More GitHub action improvements (#42)

* More descriptive filenames for github actions

* improve docker images by tagging latest when relevant
---
 ...d-on-release.yaml => build-binaries-and-brew.yaml} |  0
 ...-publish-release.yaml => build-docker-images.yaml} | 11 +++++++++++
 2 files changed, 11 insertions(+)
 rename .github/workflows/{build-on-release.yaml => build-binaries-and-brew.yaml} (100%)
 rename .github/workflows/{build-on-publish-release.yaml => build-docker-images.yaml} (65%)

diff --git a/.github/workflows/build-on-release.yaml b/.github/workflows/build-binaries-and-brew.yaml
similarity index 100%
rename from .github/workflows/build-on-release.yaml
rename to .github/workflows/build-binaries-and-brew.yaml
diff --git a/.github/workflows/build-on-publish-release.yaml b/.github/workflows/build-docker-images.yaml
similarity index 65%
rename from .github/workflows/build-on-publish-release.yaml
rename to .github/workflows/build-docker-images.yaml
index 710e1e62..199f3d13 100644
--- a/.github/workflows/build-on-publish-release.yaml
+++ b/.github/workflows/build-docker-images.yaml
@@ -47,6 +47,17 @@ jobs:
         build-args: |
           BUILDKIT_INLINE_CACHE=1
 
+    # Note: this ignores the "Set as latest release" checkbox in the GitHub UI
+    # it isn't possible to check whether that was set or not
+    # so if you do not want to override the "latest" tag, you should mark the release as a prerelease or a draft
+    # for prereleases and drafts we don't tag latest 
+    - name: Tag and push Docker image as latest if applicable
+      if: ${{ github.event.release.prerelease == false && github.event.release.draft == false }}
+      run: |
+        docker pull us-central1-docker.pkg.dev/genuine-flight-317411/devel/holmes:${{ github.ref_name }}
+        docker tag us-central1-docker.pkg.dev/genuine-flight-317411/devel/holmes:${{ github.ref_name }} us-central1-docker.pkg.dev/genuine-flight-317411/devel/holmes:latest
+        docker push us-central1-docker.pkg.dev/genuine-flight-317411/devel/holmes:latest
+
     - name: Save artifact with helm chart
       uses: actions/upload-artifact@v2
       with: