From 916b4e0c3b37ff269d8311592aa93c3e952222ed Mon Sep 17 00:00:00 2001
From: Marco Randazzo <marco.randazzo@iit.it>
Date: Wed, 22 Jan 2025 00:45:19 +0100
Subject: [PATCH] Improved ImageFile.cpp (file is now closed on error)

---
 src/libYARP_sig/src/yarp/sig/ImageFile.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/libYARP_sig/src/yarp/sig/ImageFile.cpp b/src/libYARP_sig/src/yarp/sig/ImageFile.cpp
index 190d38c1a16..8852b3bb57a 100644
--- a/src/libYARP_sig/src/yarp/sig/ImageFile.cpp
+++ b/src/libYARP_sig/src/yarp/sig/ImageFile.cpp
@@ -167,6 +167,7 @@ bool ImageReadRGB_PNG(ImageOf<PixelRgb>& img, const char* filename)
     png_structp png = png_create_read_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL);
     if (!png)
     {
+        fclose(fp);
         yCError(IMAGEFILE) << "PNG internal error";
         return false;
     }
@@ -174,12 +175,14 @@ bool ImageReadRGB_PNG(ImageOf<PixelRgb>& img, const char* filename)
     png_infop info = png_create_info_struct(png);
     if (!info)
     {
+        fclose(fp);
         yCError(IMAGEFILE) << "PNG internal error";
         return false;
     }
 
     if (setjmp(png_jmpbuf(png)))
     {
+        fclose(fp);
         yCError(IMAGEFILE) << "PNG internal error";
         return false;
     }