Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"use strict" is not in effect #492

Open
slrem opened this issue Apr 3, 2023 · 7 comments
Open

"use strict" is not in effect #492

slrem opened this issue Apr 3, 2023 · 7 comments

Comments

@slrem
Copy link

slrem commented Apr 3, 2023

"use strict" is not in effect

@donatj

This comment was marked as outdated.

@Asday
Copy link

Asday commented Apr 3, 2023

What? It's an ES5 runtime with the caveat that "use strict"; has no effect.

"use strict" will parse, but does nothing.
Otto targets ES5

https://github.com/robertkrimen/otto#caveat-emptor

@stevenh
Copy link
Collaborator

stevenh commented Apr 3, 2023

I believe what @slrem is trying to say is that while "use strict" parses, it doesn't produce the desired effect and prevent the use of undeclared variables for example, which while documented isn't ideal.

Is that the case @slrem?

@Asday
Copy link

Asday commented Apr 3, 2023

That was my understanding too - my hope was that quoting both lines from the README would answer both posts. I should have @'d people to be clear.

@slrem
Copy link
Author

slrem commented Apr 4, 2023

yes

@slrem slrem closed this as completed Apr 4, 2023
@stevenh
Copy link
Collaborator

stevenh commented Apr 4, 2023

Happy for someone to put in a PR that addresses this current short coming.

@stevenh
Copy link
Collaborator

stevenh commented Apr 4, 2023

I'll keep this open so people can see that it's something that they can help contribute to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants