Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation overhaul #95

Open
roaldarbol opened this issue Jan 4, 2025 · 0 comments
Open

Input validation overhaul #95

roaldarbol opened this issue Jan 4, 2025 · 0 comments
Labels
enhancement New feature or request triage Needs to be triaged
Milestone

Comments

@roaldarbol
Copy link
Owner

roaldarbol commented Jan 4, 2025

Currently it's become a bit sporadic, with some ensure_ and validate_ functions, and then also lots of loose input validations happening, especially in newer functions. I should return to such functions, streamline them and use them across the package.

Before going too far, it's worth checking whether the validate package, might be the right tool for this (might also work well for the general data checks!).

Maybe ensure_ and/or validate_ functions should have a parameter to either return TRUE/FALSE or return error/pass, to avoid the need for extra functions when a boolean output is needed.

@roaldarbol roaldarbol added enhancement New feature or request triage Needs to be triaged labels Jan 4, 2025
@roaldarbol roaldarbol added this to the Version 1.0 milestone Jan 4, 2025
@roaldarbol roaldarbol moved this to 🔬 Triage in animovement progress Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Needs to be triaged
Projects
Status: 🔬 Triage
Development

No branches or pull requests

1 participant