Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move building and release to GHA #7

Open
ronaldtse opened this issue Jan 1, 2020 · 3 comments
Open

Move building and release to GHA #7

ronaldtse opened this issue Jan 1, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link
Contributor

As title.

@ronaldtse ronaldtse added the enhancement New feature or request label Jan 1, 2020
rrrooommmaaa added a commit that referenced this issue Feb 15, 2020
@rrrooommmaaa
Copy link

@dewyatt @ronaldtse Looks like we need to add secrets.PACKAGE_SIGNING_KEY_BASE64 and secrets.GITHUB_YUM_DEPLOY_KEY_BASE64 here. Also, there is github-release stage here, so I would need GITHUB_API_TOKEN too.
Do we still need to keep references to github.com/riboseinc/rpm-specs ?

rrrooommmaaa added a commit that referenced this issue Feb 22, 2020
@skalee
Copy link

skalee commented Feb 23, 2020

@rrrooommmaaa You should have GitHub API token for the current repo out of the box. (Am I correct that this is the issue?) See: https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token.

@ronaldtse
Copy link
Contributor Author

@rrrooommmaaa sorry for missing this!

We do not need to reference https://github.com/riboseinc/rpm-specs .

@ribose-jeffreylau could you help setup these secrets (org-wide):

  • PACKAGE_SIGNING_KEY_BASE64
  • GITHUB_YUM_DEPLOY_KEY_BASE64

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants