Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAP_ENGINE_REGIONS in distilling is legacy? #24

Open
nesnoj opened this issue Oct 21, 2024 · 0 comments
Open

MAP_ENGINE_REGIONS in distilling is legacy? #24

nesnoj opened this issue Oct 21, 2024 · 0 comments
Assignees
@henhuy
Labels
question Further information is requested

Comments

@nesnoj
Copy link
Member

nesnoj commented Oct 21, 2024

We removed the var MAP_ENGINE_REGIONS in the EPP app. However, here it is still required when distilling is activated.
It belongs to the special treatment of regions removed recently, doesn't it? Can we simply change it to source=f"{self.source}_distilled" ?
@nesnoj nesnoj added the question Further information is requested label Oct 21, 2024
@nesnoj nesnoj changed the title MAP_ENGINE_REGIONS for distilling is legacy? MAP_ENGINE_REGIONS in distilling is legacy? Oct 21, 2024
nesnoj added a commit to empowerplan/epp-app that referenced this issue Nov 5, 2024
@nesnoj
Keep legacy env var MAP_ENGINE_REGIONS in base.py
fcfa18f 
cf. rl-institut/django-mapengine#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henhuy henhuy

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nesnoj @henhuy