Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AML_070 doesn't require implementation of Get/Set Real Time? #184

Closed
jhauser-us opened this issue Jul 30, 2024 · 4 comments
Closed

AML_070 doesn't require implementation of Get/Set Real Time? #184

jhauser-us opened this issue Jul 30, 2024 · 4 comments
Assignees
Labels

Comments

@jhauser-us
Copy link

For AML_070, when a system must implement the Time and Alarm Device, is it acceptable not to implement the Get/Set Real Time methods (_GRT, _SRT), and have _GCP return a value with bit 2 = 0?

@andreiw
Copy link
Collaborator

andreiw commented Aug 6, 2024

A TAD device is an appropriate choice for RTC when the RTC access needs to interlock with some other OS code, because the RTC shares a bus with some other device of interest that is being managed by an OS.

If the RTC is implemented via TAD, then it cannot be implemented via UEFI RT (the URT_020 rule).

The AML_070 rule was specifically around implementing time access, so this rule implies _GRT and _SRT are implemented and _GCP returns bit 2 = 1.

@jhauser-us
Copy link
Author

this rule implies _GRT and _SRT are implemented and _GCP returns bit 2 = 1.

That's not good enough.

The point of this issue is that AML_070 does not say that _GRT and _SRT must be implemented. It's unwise to assume readers will always understand your motivations and therefore always deduce the correct implications. Worse, you're making it too easy for implementors to purposefully skirt the rule with the excuse that "it doesn't actually say that".

Is there some objection to making AML_070 clearer about the intention?

@andreiw
Copy link
Collaborator

andreiw commented Aug 8, 2024

No objections. Will rework the text for clarity.

@andreiw
Copy link
Collaborator

andreiw commented Aug 8, 2024

#193

@andreiw andreiw self-assigned this Aug 8, 2024
@andreiw andreiw added the fixed label Aug 13, 2024
@andreiw andreiw closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants