Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnableAmendment/Simple.tsx should be translatable #1076

Closed
tequdev opened this issue Nov 7, 2024 · 1 comment
Closed

EnableAmendment/Simple.tsx should be translatable #1076

tequdev opened this issue Nov 7, 2024 · 1 comment

Comments

@tequdev
Copy link
Contributor

tequdev commented Nov 7, 2024

explorer/src/containers/shared/components/Transaction/EnableAmendment/Simple.tsx

Line 59 in 5a93a6d

<SimpleRow label="Amendment Name" data-test="name">

like

<SimpleRow label={t("amendment_name")} data-test="name">
@achowdhry-ripple achowdhry-ripple mentioned this issue Nov 12, 2024
Merged
10 tasks
@achowdhry-ripple
Copy link
Collaborator

Resolved in #1084

achowdhry-ripple added a commit that referenced this issue Nov 13, 2024
@achowdhry-ripple
Add Simple Enable Amendment Translations (#1084)
dae75f4 
## High Level Overview of Change

Add translations to the EnableAmendment/Simple.tsx file for the table
labels. Small code cleanup raised in
#1076

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

### TypeScript/Hooks Update

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tequdev @achowdhry-ripple