Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate handling DuckDB schemas safely #6460

Open
begelundmuller opened this issue Jan 21, 2025 · 0 comments
Open

Investigate handling DuckDB schemas safely #6460

begelundmuller opened this issue Jan 21, 2025 · 0 comments
Assignees

Comments

@begelundmuller
Copy link
Contributor

begelundmuller commented Jan 21, 2025

Following up on this thread: https://rilldata.slack.com/archives/CTCJ58H3M/p1736339712522279?thread_ts=1736192001.051219&cid=CTCJ58H3M.

We actually also have some code that captures the current database/schema in the model reconciler and other places. I wonder if that can lead to some inconsistencies if the external table storage version gets captured there.

I'm wondering if we should just always return "main" or "" in the information schema listings to give the appearance of it being one schema, and then audit the code to avoid ever making fully qualified table names (i.e. database.schema.table) in our code. If a user has a fully qualified table name in their model code, it's acceptable to error.

@begelundmuller begelundmuller changed the title Expose consistent DuckDB schema in the information schema Handle the DuckDB schema consistently in the information schema Jan 21, 2025
@begelundmuller begelundmuller changed the title Handle the DuckDB schema consistently in the information schema Investigate handling DuckDB schemas safely Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants