remove import of potentialFilterName from dimension-filters.ts and side-effect mutating it from toggleDimensionValueSelection

[bcolloran]

No description provided.

[bcolloran]

Hey @briangregoryholmes and @ericpgreen2 , I didn't see #3728 until just now while cleaning up some other stuff.

Brian, there is no way you could have known this since it's unfortunately undocumented anywhere, but the intent is that all the actions and selectors in the state-managers folder should be pure function with no side effects, which importing the store potentialFilterName into dimension-filters.ts and updating it within the toggleDimensionValueSelection violates.

Not a big deal, and easy to rectify. I can take this issue if you want, or if you want to grab it that's fine too, just LMK :-)

[bcolloran]

Obsolete following a recent PR