New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Add Source dialog should show a warning when a URI does not contain a file format #3784

Open

ericpgreen2 opened this issue Jan 5, 2024 · 0 comments

Contributor

ericpgreen2 commented Jan 5, 2024 •

edited

Loading

Without a file format, the built DuckDB query will fail, so we should warn the user ahead-of-time.

Some solution ideas:

Add a new validation condition to each relevant connector's Yup schema. However, Yup natively only supports errors not warnings. We might be able to extend Yup with a custom warning function, but we'd also need to ensure our form library can visualize the warning.
We could show a Yup error, prevent form submission, and instruct users to eject to the Source editor to write the DuckSQL themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment