From d3a1ed0ab7dfdcdd29d8530e97c34f8701bab8ca Mon Sep 17 00:00:00 2001
From: Alexander Thor <alec.karlsson@gmail.com>
Date: Tue, 4 Feb 2025 21:34:07 +0100
Subject: [PATCH] fix: some more testing fixes

---
 web-local/tests/explores/explores.spec.ts           | 13 ++++++++-----
 .../explores/leaderboard-context-column.spec.ts     |  2 +-
 web-local/tests/explores/number-formatting.spec.ts  |  2 +-
 .../explores/time-controls-from-config.spec.ts      |  2 +-
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/web-local/tests/explores/explores.spec.ts b/web-local/tests/explores/explores.spec.ts
index 3f1f0778c5c..f3b6ebabebc 100644
--- a/web-local/tests/explores/explores.spec.ts
+++ b/web-local/tests/explores/explores.spec.ts
@@ -44,7 +44,7 @@ test.describe("explores", () => {
       assertLeaderboards(page, [
         {
           label: "Publisher",
-          values: ["null", "Facebook", "Google", "Yahoo", "Microsoft"],
+          values: ["null", "Facebook", "Microsoft", "Google", "Yahoo"],
         },
         {
           label: "Domain",
@@ -74,6 +74,9 @@ test.describe("explores", () => {
       await page.getByRole("menuitem", { name: "All Time" }).click();
     });
 
+    // Turn on comparison
+    await page.getByRole("button", { name: "Comparing" }).click();
+
     // Check the total records are 100k
     await expect(page.getByText("Total records 100k")).toBeVisible();
 
@@ -225,7 +228,7 @@ test.describe("explores", () => {
     const changeDisplayNameDoc = `
 type: explore
 
-title: "Adbids dashboard renamed"
+display_name: "Adbids dashboard renamed"
 metrics_view: AdBids_model_metrics
 
 dimensions: '*'
@@ -257,7 +260,7 @@ measures: '*'
 
     version: 1
     type: metrics_view
-    title: "AdBids_model_dashboard"
+    display_name: "AdBids_model_dashboard"
     model: "AdBids_model"
     default_time_range: ""
     smallest_time_grain: "week"
@@ -304,7 +307,7 @@ measures: '*'
 
     version: 1
     type: metrics_view
-    title: "AdBids_model_dashboard"
+    display_name: "AdBids_model_dashboard"
     model: "AdBids_model"
     default_time_range: ""
     smallest_time_grain: "week"
@@ -333,7 +336,7 @@ measures: '*'
 
 version: 1
 type: metrics_view
-title: "AdBids_model_dashboard_rename"
+display_name: "AdBids_model_dashboard_rename"
 model: "AdBids_model"
 default_time_range: ""
 smallest_time_grain: "week"
diff --git a/web-local/tests/explores/leaderboard-context-column.spec.ts b/web-local/tests/explores/leaderboard-context-column.spec.ts
index 7fa83059caa..44c2822ebeb 100644
--- a/web-local/tests/explores/leaderboard-context-column.spec.ts
+++ b/web-local/tests/explores/leaderboard-context-column.spec.ts
@@ -23,7 +23,7 @@ test.describe("leaderboard context column", () => {
 
   version: 1
   type: metrics_view
-  title: "AdBids_model_dashboard"
+  display_name: "AdBids_model_dashboard"
   model: "AdBids_model"
   default_time_range: ""
   smallest_time_grain: ""
diff --git a/web-local/tests/explores/number-formatting.spec.ts b/web-local/tests/explores/number-formatting.spec.ts
index 7198947e782..1810d848de2 100644
--- a/web-local/tests/explores/number-formatting.spec.ts
+++ b/web-local/tests/explores/number-formatting.spec.ts
@@ -20,7 +20,7 @@ test.describe("smoke tests for number formatting", () => {
     // This is a metrics spec with all available formatting options
     const formatterFlowDashboard = `# Visit https://docs.rilldata.com/reference/project-files to learn more about Rill project files.
 kind: metrics_view
-title: "AdBids_model_dashboard"
+display_name: "AdBids_model_dashboard"
 model: "AdBids_model"
 timeseries: "timestamp"
 measures:
diff --git a/web-local/tests/explores/time-controls-from-config.spec.ts b/web-local/tests/explores/time-controls-from-config.spec.ts
index 205d26f03f2..eca98047db2 100644
--- a/web-local/tests/explores/time-controls-from-config.spec.ts
+++ b/web-local/tests/explores/time-controls-from-config.spec.ts
@@ -234,7 +234,7 @@ test.describe("time controls settings from explore preset", () => {
 function getDashboardYaml(defaults: string, extras = "") {
   return `
 type: explore
-title: "AdBids_model_metrics_explore"
+display_name: "AdBids_model_metrics_explore"
 metrics_view: "AdBids_model_metrics"
 ${extras}