From 92c48da274271142e5cfd88172a737f0d3d97d9e Mon Sep 17 00:00:00 2001 From: Anshul Khandelwal <12948312+k-anshul@users.noreply.github.com> Date: Wed, 5 Feb 2025 09:51:11 +0530 Subject: [PATCH] release snapshot on all error paths in AcquireReadConnection (#6586) --- runtime/pkg/rduckdb/db.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/runtime/pkg/rduckdb/db.go b/runtime/pkg/rduckdb/db.go index 7a1792165b9..8ee382c67c6 100644 --- a/runtime/pkg/rduckdb/db.go +++ b/runtime/pkg/rduckdb/db.go @@ -302,11 +302,13 @@ func (d *db) AcquireReadConnection(ctx context.Context) (*sqlx.Conn, func() erro conn, err := d.dbHandle.Connx(ctx) if err != nil { + d.catalog.releaseSnapshot(snapshot) return nil, nil, err } err = d.prepareSnapshot(ctx, conn, snapshot) if err != nil { + d.catalog.releaseSnapshot(snapshot) _ = conn.Close() return nil, nil, err }