-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for zombie, memory, and pipe leaks #36
Comments
We removed all semaphores in #33 so at least that's sorted. |
richardsheridan
changed the title
Test for zombie, semaphore, and pipe leaks. (and memory?)
Test for zombie, memory, and pipe leaks
Apr 8, 2021
There is at least one situation where we have a pipe leak, which is whenever an ACK is not received on windows: trio-parallel/trio_parallel/_proc.py Lines 72 to 93 in 22b96bd
I consider this an upstream bug (python/cpython#114720), but basically I would have caught this back in 2021 with these kind of tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had originally assumed that
multiprocessing
was going to take care of all this for us, but in #34 @zgoda claims thathypercorn --debug -k trio
somehow leads to a semaphore leak on eachrun_sync
invocation. Since we are doing Readme Driven Development and claim "no leaks" we should develop the automated tests to show that there are no leaks in a suite of example usages and regression tests.The text was updated successfully, but these errors were encountered: