From c3beaf6bada107bd3abe1a789c7bd66d7137d3a8 Mon Sep 17 00:00:00 2001 From: Roy Hashimoto Date: Thu, 19 Sep 2024 11:25:09 -0700 Subject: [PATCH 1/2] Fix set_authorizer() callback arguments. --- src/sqlite-api.js | 4 ++-- test/callbacks.test.js | 14 +++++++++++++- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/sqlite-api.js b/src/sqlite-api.js index 2d29f90b..06693497 100644 --- a/src/sqlite-api.js +++ b/src/sqlite-api.js @@ -630,8 +630,8 @@ export function Factory(Module) { }; function adapt(f) { return f instanceof AsyncFunction ? - (async (_, iAction, p3, p4, p5, p6) => f(cvtArgs(_, iAction, p3, p4, p5, p6))) : - ((_, iAction, p3, p4, p5, p6) => f(cvtArgs(_, iAction, p3, p4, p5, p6))); + (async (_, iAction, p3, p4, p5, p6) => f(...cvtArgs(_, iAction, p3, p4, p5, p6))) : + ((_, iAction, p3, p4, p5, p6) => f(...cvtArgs(_, iAction, p3, p4, p5, p6))); } const result = Module.set_authorizer(db, adapt(xAuth), pApp); diff --git a/test/callbacks.test.js b/test/callbacks.test.js index 6b3da5cb..023e941c 100644 --- a/test/callbacks.test.js +++ b/test/callbacks.test.js @@ -338,7 +338,19 @@ for (const [key, factory] of FACTORIES) { rc = await sqlite3.exec(db, 'CREATE TABLE t(x)'); expect(rc).toEqual(SQLite.SQLITE_OK); - expect(authorizations.length).toBeGreaterThan(0); + let authCreateTable = false; + for (const authorization of authorizations) { + switch (authorization[0]) { + case SQLite.SQLITE_CREATE_TABLE: + authCreateTable = true; + expect(authorization[1]).toEqual('t'); + expect(authorization[2]).toEqual(''); + expect(authorization[3]).toEqual('main'); + expect(authorization[4]).toEqual(''); + break; + } + } + expect(authCreateTable).toBeTrue(); }); it('should deny authorization', async function() { From 60d42e88228f5c6fc1e3e63b5814e0ba03ff2e10 Mon Sep 17 00:00:00 2001 From: Roy Hashimoto Date: Thu, 19 Sep 2024 11:55:11 -0700 Subject: [PATCH 2/2] Bump version. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ab857f56..17a004f6 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "wa-sqlite", - "version": "1.0.1", + "version": "1.0.2", "type": "module", "main": "src/sqlite-api.js", "types": "src/types/index.d.ts",