From e78b5c0d02a848ff1f033eafcf722fc8525094a0 Mon Sep 17 00:00:00 2001
From: Leo Ochoa <lochoa@redhat.com>
Date: Tue, 14 Jun 2022 08:13:18 +0200
Subject: [PATCH] Fix deploy-metallb to pass shellcheck linter

https://github.com/koalaman/shellcheck/wiki/SC2068
---
 deploy-metallb/deploy.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/deploy-metallb/deploy.sh b/deploy-metallb/deploy.sh
index dcc782220..757298d8a 100755
--- a/deploy-metallb/deploy.sh
+++ b/deploy-metallb/deploy.sh
@@ -192,7 +192,7 @@ function copy_files() {
     dst_folder=${3}
 
     if [[ -z ${src_files} ]]; then
-        echo "Source files variable empty: ${src_files[@]}"
+        echo "Source files variable empty:" "${src_files[@]}"
         exit 1
     fi
 
@@ -206,8 +206,8 @@ function copy_files() {
         exit 1
     fi
 
-    echo "Copying source files: ${src_files[@]} to Node ${dst_node}"
-    ${SCP_COMMAND} -i ${RSA_KEY_FILE} ${src_files[@]} core@${dst_node}:${dst_folder}
+    echo "Copying source files:" "${src_files[@]}" "to Node ${dst_node}"
+    ${SCP_COMMAND} -i ${RSA_KEY_FILE} "${src_files[@]}" core@${dst_node}:${dst_folder}
 }
 
 function check_external_access() {
@@ -272,7 +272,7 @@ if ! ./verify.sh; then
         # Remote working
         echo ">> Copying files to the Edge-cluster ${edgecluster}"
         ${SSH_COMMAND} -i ${RSA_KEY_FILE} core@${EDGE_NODE_IP} "mkdir -p ~/manifests ~/.kube"
-        for _file in ${files[@]}; do
+        for _file in "${files[@]}"; do
             copy_files "${_file}" "${EDGE_NODE_IP}" "./manifests/"
         done
         copy_files "./manifests/*.yaml" "${EDGE_NODE_IP}" "./manifests/"