Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit dirs from executable searches #236

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: omit dirs from executable searches #236

merged 1 commit into from
Oct 25, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Oct 25, 2024

We were already filtering on executables, but forgot to filter on being a file. Among other things, this fixed an issue spotted in completion of help topics.

Copy link

github-actions bot commented Oct 25, 2024

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.42 μs 3.41 μs -0.00 μs ⚪ Unchanged
instantiate_shell 61.90 μs 59.68 μs -2.22 μs 🟢 -3.58%
instantiate_shell_with_init_scripts 30469.18 μs 30359.30 μs -109.88 μs ⚪ Unchanged
parse_bash_completion 2791.95 μs 2796.06 μs 4.11 μs ⚪ Unchanged
parse_sample_script 4.26 μs 4.38 μs 0.12 μs 🟠 +2.82%
run_echo_builtin_command 92.01 μs 89.22 μs -2.79 μs 🟢 -3.04%
run_one_builtin_command 111.03 μs 107.48 μs -3.55 μs ⚪ Unchanged
run_one_external_command 1949.15 μs 1957.47 μs 8.33 μs ⚪ Unchanged
run_one_external_command_directly 1010.62 μs 1006.56 μs -4.06 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/getopts.rs 🟢 94.81% 🟢 95.12% 🟢 0.31%
brush-core/src/sys/unix/signal.rs 🟠 72.13% 🟢 75.41% 🟢 3.28%
Overall Coverage 🟢 76.47% 🟢 76.5% 🟢 0.03%

Minimum allowed coverage is 70%, this run produced 76.5%

@reubeno reubeno enabled auto-merge (squash) October 25, 2024 03:48
@reubeno reubeno merged commit 1efdbf8 into main Oct 25, 2024
11 checks passed
@reubeno reubeno deleted the exec-search branch October 25, 2024 03:53
Copy link

Test Results

  2 files    9 suites   1m 5s ⏱️
497 tests 497 ✅ 0 💤 0 ❌
983 runs  983 ✅ 0 💤 0 ❌

Results for commit b401580.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant