Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct pattern removal expansions on arrays #232

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Oct 24, 2024

This was missed when the other expansions were retrofitted to support arrays; uses existing transform_expansion helper to simplify the work of iteratively transforming all elements of the array.

Copy link

Test Results

  2 files    9 suites   1m 5s ⏱️
496 tests 496 ✅ 0 💤 0 ❌
981 runs  981 ✅ 0 💤 0 ❌

Results for commit 08d0360.

Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.42 μs 3.42 μs 0.00 μs ⚪ Unchanged
instantiate_shell 59.78 μs 60.96 μs 1.17 μs 🟠 +1.96%
instantiate_shell_with_init_scripts 30315.31 μs 30893.21 μs 577.90 μs ⚪ Unchanged
parse_bash_completion 2770.09 μs 2798.12 μs 28.03 μs 🟠 +1.01%
parse_sample_script 4.27 μs 4.28 μs 0.01 μs ⚪ Unchanged
run_echo_builtin_command 89.03 μs 91.57 μs 2.54 μs 🟠 +2.85%
run_one_builtin_command 108.40 μs 110.63 μs 2.23 μs ⚪ Unchanged
run_one_external_command 1926.17 μs 2022.25 μs 96.08 μs 🟠 +4.99%
run_one_external_command_directly 1006.22 μs 1007.45 μs 1.23 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/expansion.rs 🟢 96.03% 🟢 96% 🔴 -0.03%
brush-core/src/shell.rs 🟢 83.5% 🟢 83.64% 🟢 0.14%
brush-core/src/sys/unix/signal.rs 🟢 75.41% 🟠 72.13% 🔴 -3.28%
Overall Coverage 🟢 76.5% 🟢 76.48% 🔴 -0.02%

Minimum allowed coverage is 70%, this run produced 76.48%

@reubeno reubeno merged commit 594407a into main Oct 24, 2024
11 checks passed
@reubeno reubeno deleted the pattern-removal-on-arrays branch October 24, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant