Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving results #5

Open
retifrav opened this issue Nov 5, 2021 · 2 comments
Open

Saving results #5

retifrav opened this issue Nov 5, 2021 · 2 comments
Assignees
Labels
task Stuff to do
Milestone

Comments

@retifrav
Copy link
Owner

retifrav commented Nov 5, 2021

Implement saving results (sent/received/lost, latency, etc). There is a button already, but it doesn't do anything at the moment.
Results could be saved in JSON format to standard system data folder (where telemetry dump goes to too) or wherever.
Saved results can perhaps be also loaded for previewing later.

@retifrav retifrav added the task Stuff to do label Nov 5, 2021
@retifrav retifrav self-assigned this Nov 5, 2021
@retifrav retifrav changed the title Save results Saving results Nov 5, 2021
@retifrav
Copy link
Owner Author

retifrav commented May 15, 2023

Saving to files might add a complexity of handling filesystem write access, which might be especially troublesome on Mac OS (the the application is sandboxed/translocated/etc) and probably Flatpak (permissions/entitlements and whatnot).

For now it would be already good to just copy the report text to clipboard.

retifrav added a commit that referenced this issue May 15, 2023
@retifrav
Copy link
Owner Author

retifrav commented May 21, 2023

And actually, let's not implement saving to disk at all. Copying to clipboard is absolutely enough: user can then save the copied text to whatever file he wants.

What could be done though is an ability to copy the report/results in a format that could be further processed, such as JSON. So there should be an additional button or a button with a dropdrown menu with the following options:

  • copy as plain text;
  • copy as JSON.

@retifrav retifrav added this to the v1.3.0 milestone May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Stuff to do
Projects
None yet
Development

No branches or pull requests

1 participant