Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non existing pages with a path with only two letters that is not a language code create parsing errors on the 'Page not found' page. #1567

Closed
misharigot opened this issue Mar 6, 2020 · 2 comments
Assignees
Labels
bug Something isn't working contrib-easy Easy dev difficulty for contribution

Comments

@misharigot
Copy link

Describe the bug
Non existing pages with a path with only two letters that is not a language code create parsing errors on the 'Page not found' page.

E.g. 'https://docs.requarks.io/ab'.

It does not happen when you go to 'https://docs.requarks.io/en'. I imagine because this is a valid language code.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://docs.requarks.io/ab' or 'https://docs.requarks.io/cd' or 'https://docs.requarks.io/xy' etc.
    This also happens when you deploy wiki.js yourself.
  2. See error

Expected behavior
Instead of notfound.* for docs.requarks.io or newpage.* in the case of the deployed wiki.js, it should show the correct content, e.g. This page does not exist yet..

Screenshots
If applicable, add screenshots to help explain your problem.

Host Info (please complete the following information):

  • OS: Ubuntu 18.04, Docker
  • Wiki.js version: 2.0.1
  • Database engine: postgres 9.7
@NGPixel NGPixel added bug Something isn't working contrib-easy Easy dev difficulty for contribution labels Mar 6, 2020
@eeshugerman
Copy link
Contributor

Similar to (or duplicate of?) #1292

@misharigot
Copy link
Author

Yes, #1292 is the same issue, thanks 👍. I closed this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contrib-easy Easy dev difficulty for contribution
Projects
None yet
Development

No branches or pull requests

3 participants