From 5252d6e54a57f0cd55373e86692dfffd5018dac1 Mon Sep 17 00:00:00 2001 From: Dmitry Marakasov Date: Tue, 12 Feb 2019 19:44:18 +0300 Subject: [PATCH] Fix UB --- libversion/compare.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libversion/compare.c b/libversion/compare.c index e03fa3d..bc16cae 100644 --- a/libversion/compare.c +++ b/libversion/compare.c @@ -67,7 +67,7 @@ enum { }; static int mymemcasecmp(const char* a, const char* b, size_t len) { - while (len-- != 0) { + while (len != 0) { unsigned char ua = (unsigned char)((*a >= 'A' && *a <= 'Z') ? (*a - 'A' + 'a') : (*a)); unsigned char ub = (unsigned char)((*b >= 'A' && *b <= 'Z') ? (*b - 'A' + 'a') : (*b)); @@ -76,6 +76,7 @@ static int mymemcasecmp(const char* a, const char* b, size_t len) { a++; b++; + len--; } return 0;