Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of parallel update requests #524

Open
asportnoy opened this issue Aug 2, 2023 · 1 comment
Open

Limit number of parallel update requests #524

asportnoy opened this issue Aug 2, 2023 · 1 comment
Assignees
Labels
available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! bug Something isn't working good first issue Good for newcomers

Comments

@asportnoy
Copy link
Member

The Replugged API has a rate limit of 20 requests per second. However, the updater currently requests all updates at once (relevant code). The check should be throttled to 15 requests per second (give some wiggle room) and properly handle 429s.

In the future, we should add a route to the backend for a bulk update check to avoid needing a lot of requests like this.

@asportnoy asportnoy added bug Something isn't working good first issue Good for newcomers available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! labels Aug 2, 2023
@bop34
Copy link
Contributor

bop34 commented Aug 2, 2023

I can take this.

@asportnoy asportnoy self-assigned this Aug 2, 2023
@asportnoy asportnoy removed the available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! label Aug 2, 2023
@asportnoy asportnoy assigned bop34 and unassigned asportnoy Aug 2, 2023
This was referenced Oct 24, 2023
@FedeIlLeone FedeIlLeone added the available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available (leave comment to claim) If you're interested in taking on this issue, please leave a comment! bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants