Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify AWS credentials in hostRules block for private Maven repos hosted directly on S3 #18745

Open
ajax-semenov-y opened this issue Nov 3, 2022 · 7 comments
Labels
auto:no-pings Reminder to users who "chase up" or hassle about topics datasource:maven priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@ajax-semenov-y
Copy link

What would you like Renovate to be able to do?

This request is an enhancement for the #13825

AFAIU, it is only possible to pass AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY as environment variables if I want to use private maven repo hosted on S3, which is not possible when running Renovate as App on GitHub(https://github.com/apps/renovate) that hosted by Mend. So it would be good to have the ability to pass AWS credentials in the hostRules block.

If you have any ideas on how this should be implemented, please tell us here.

It can be implemented like username/password fields for the Artifactory:

{
  "hostRules": [
    {
      "matchHost": "s3://my-private-maven-repo/snapshots",
      "hostType": "maven",
      "encrypted": {
        "accessKey": "...",
        "secretKey": "..."
      }
    }
  ]
}

For example, something similar is implemented in Gradle:

repositories {
    maven {
        url = URI("s3://my-private-maven-repo/snapshots")
        credentials(AwsCredentials::class.java) {
            accessKey = "..."
            secretKey = "..."
        }
    }
}

Is this a feature you are interested in implementing yourself?

No

@ajax-semenov-y ajax-semenov-y added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Nov 3, 2022
@ajax-semenov-y
Copy link
Author

Unfortunately, I'm not so familiar with typescript to implement it by myself.

@viceice
Copy link
Member

viceice commented Nov 3, 2022

we can reuse username and password fields for it.

@viceice viceice added datasource:maven priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Nov 3, 2022
@ajax-semenov-y
Copy link
Author

we can reuse username and password fields for it.

It is also a good way to go, but I'm afraid it can confuse users

@viceice
Copy link
Member

viceice commented Nov 3, 2022

should simply be well documented. we do same for AWS code commit

@nosajsnikta
Copy link

Has there been any progress on a solution for this issue or is the passing of AWS credentials option in a self-hosted renovate the only option?

@StasKolodyuk

This comment has been minimized.

@rarkins rarkins added the auto:no-pings Reminder to users who "chase up" or hassle about topics label Oct 21, 2024
Copy link
Contributor

Hi there,

Please do not post comments like: "Any update on this?" or "When will this be fixed?".

If you're asking because you want to know if there's been some progress, then please know that we work in the open in this repo. If there was an update to this Discussion or Issue, you would see it already. So please don't ask "just in case".

If you're asking because you want to get our attention, then please don't do that either. It wastes maintainer time and pollutes the repo. You're welcome to fix issues yourself, hire someone to help you, or wait for someone else to do the work. You're not welcome to post the equivalent of "Hey, someone else should really do something about this".

If you are a paying Mend.io customer, contact your support or customer success representative, and tell them this issue is important to you.

We expect everyone to follow these rules, no matter if you use the free tiers, or are a paying Mend customer. Please read our Code of Conduct, how we prioritize work to learn more about how we prioritize what to work on.

Thanks, the Renovate team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:no-pings Reminder to users who "chase up" or hassle about topics datasource:maven priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

5 participants