Invalid deps are shown on dashboard detected dependencies

[viceice]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

We still show invalid deps on dashboard

visualon/docker-proget#1

regression of ?

• feat(core/dashboard): include list of detected package files #15418

Relevant debug logs

Logs

DEBUG: packageFiles with updates
{
  "baseBranch": "main",
  "config": {
    "docker-compose": [
      {
        "packageFile": "linux/docker-compose.test.yml",
        "deps": [
          {
            "skipReason": "invalid-name",
            "replaceString": "${IMAGE}",
            "autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}",
            "datasource": "docker",
            "depIndex": 0,
            "updates": []
          }
        ]
      }
    ],
    "dockerfile": [
      {
        "packageFile": "linux/Dockerfile",
        "deps": [
          {
            "depName": "proget.inedo.com/productimages/inedo/proget",
            "currentValue": "22.0.5",
            "currentDigest": "sha256:ad625caaf9200022c5016fe8f8677c4089c210cc1780a7934b6a06c9a646ca9f",
            "replaceString": "proget.inedo.com/productimages/inedo/proget:22.0.5@sha256:ad625caaf9200022c5016fe8f8677c4089c210cc1780a7934b6a06c9a646ca9f",
            "autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}",
            "datasource": "docker",
            "depType": "final",
            "depIndex": 0,
            "updates": [],
            "warnings": [],
            "versioning": "docker",
            "currentVersion": "22.0.5",
            "fixedVersion": "22.0.5"
          }
        ]
      }
    ],
    "github-actions": [
      {
        "packageFile": ".github/workflows/build.yml",
        "deps": [
          {
            "depName": "actions/checkout",
            "commitMessageTopic": "{{{depName}}} action",
            "datasource": "github-tags",
            "versioning": "regex:^v(?<major>\\d+)(\\.(?<minor>\\d+)\\.(?<patch>\\d+))?$",
            "depType": "action",
            "replaceString": "actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3.0.2",
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # tag={{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "currentValue": "v3.0.2",
            "currentDigest": "2541b1294d2704b0964813337f33b291d3f8596b",
            "depIndex": 0,
            "updates": [],
            "warnings": [],
            "sourceUrl": "https://github.com/actions/checkout",
            "currentVersion": "v3.0.2",
            "fixedVersion": "v3.0.2"
          },
          {
            "depName": "renovatebot/internal-tools",
            "commitMessageTopic": "{{{depName}}} action",
            "datasource": "github-tags",
            "versioning": "regex:^v(?<major>\\d+)(\\.(?<minor>\\d+)\\.(?<patch>\\d+))?$",
            "depType": "action",
            "replaceString": "renovatebot/internal-tools@ac2a85780492e013c8fa9d87aa72a788b78fbd58 # tag=v1.14.2",
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # tag={{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "currentValue": "v1.14.2",
            "currentDigest": "ac2a85780492e013c8fa9d87aa72a788b78fbd58",
            "depIndex": 1,
            "updates": [],
            "warnings": [],
            "sourceUrl": "https://github.com/renovatebot/internal-tools",
            "currentVersion": "v1.14.2",
            "fixedVersion": "v1.14.2"
          }
        ]
      }
    ]
  }
}

Have you created a minimal reproduction repository?

No reproduction, but I have linked to a public repo where it occurs

[viceice]

I think we should filter all deps with a skipReason

[betterPeleg]

@Gabriel-Ladzaretti Do you have any input?

[Gabriel-Ladzaretti]

i wonder how the PackageFiles with updates looks like, did we extract undefined dep?
ill try to reproduce locally out of curiosity

[viceice]

@Gabriel-Ladzaretti chekout my linked repo and the log above. the docker dep contains a variable, so it's skipped here

renovate/lib/modules/manager/dockerfile/extract.ts

Lines 110 to 115 in fd0e943

	if (cleanedCurrentFrom?.includes(variableMarker)) {
	// If cleanedCurrentFrom contains a variable, after cleaning, e.g. "$REGISTRY/alpine", we do not support this.
	return {
	skipReason: 'contains-variable',
	};
	}

simple reproduction:

FROM $IMAGE

[Gabriel-Ladzaretti]

Reproduced locally, I wasn't aware of this scenario really
ladzaretti/dash-undefiend-dep#1

[renovate-release]

🎉 This issue has been resolved in version 32.165.1 🎉

The release is available on:

• GitHub release
• 32.165.1

Your semantic-release bot 📦🚀