Updated the composer json because when you try to install the pacakge… #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with composer in laravel 10 it does not work and gives compatibility issue errors, I have fixed it by updating the composer.json file for the project.
|
Any updates on this? @renatomarinho |
|
@renatomarinho can you merge this, please? |
|
@renatomarinho kindly review. 😄 |
tvbeek
approved these changes
May 9, 2023
|
my question is, why did this small mistake get through |
|
Can you merge these changes as other people face the same issue, @renatomarinho ? 😄 |
zhinea
approved these changes
Jun 6, 2023
|
up ? @renatomarinho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… with composer in laravel 10 it does not work and gives compatibility issue errors, I have fixed it by updating the composer.json file for the project.
Description
When I tried to install this package in my new Laravel 10 project I faced an issue that the package was not compatible. So I went to the repo and took a look at the issues, someone tried to fix it but did not update properly and that code was merged in the master branch, but it is not working. So I created this pull request and fixed the issue.
Motivation and context
Mentioned above 😄
Why is this change required? What problem does it solve?
This change is required so that the package is installable via composer properly and devs don't have to install this package manually. This fixes issue #172 which was merged.
How has this been tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!