Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement zod type for google fonts #2692

Open
alexfernandez803 opened this issue Aug 6, 2023 · 5 comments · May be fixed by #4284
Open

implement zod type for google fonts #2692

alexfernandez803 opened this issue Aug 6, 2023 · 5 comments · May be fixed by #4284
Assignees
@erayerdin

Comments

@alexfernandez803
Copy link
Contributor

Feature Request 🛍️

It would be beneficial to have a combobox or picker to select google fonts similar to zColor. This will improve the dev experience to easily select a font while development.

Use Case

Possible Solution

Extend https://www.remotion.dev/docs/zod-types/ to add a z-google-font with a zGoogleFont type
@JonnyBurger
Copy link
Member

Sounds good to me, since google fonts is a huge package though, it would be better if it does not become a dependency of @remotion/zod-types.

So maybe we only copy a list of the fonts as a string array into the zod-types package?

@alexfernandez803
Copy link
Contributor Author

Yep, we could just create a script to generate an array from getAvailableFonts() tho write a file containing the font array.

Does the studio support combobox right now?

@JonnyBurger
Copy link
Member

The studio does do that yes! It is just z.enum

@erayerdin
Copy link

Can I take this on? This will be my first time contributing to this project. :)

@JonnyBurger
Copy link
Member

@erayerdin That would be awesome!
Thanks for giving it an attempt! 🙌

@erayerdin erayerdin linked a pull request Sep 5, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erayerdin erayerdin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement zGoogleFont zod type erayerdin/remotion
3 participants
@JonnyBurger @erayerdin @alexfernandez803