Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megacheck report #12

Open
meling opened this issue Nov 15, 2017 · 0 comments
Open

Megacheck report #12

meling opened this issue Nov 15, 2017 · 0 comments
Assignees

Comments

@meling
Copy link
Member

meling commented Nov 15, 2017

% megacheck ./...
raftgorums/integration_test.go:184:3: the goroutine calls T.FailNow, which must be called in the same goroutine as the test (SA2002)
raftgorums/integration_test.go:238:3: the goroutine calls T.FailNow, which must be called in the same goroutine as the test (SA2002)
raftgorums/integration_test.go:297:3: the goroutine calls T.FailNow, which must be called in the same goroutine as the test (SA2002)
raftgorums/integration_test.go:393:3: the goroutine calls T.FailNow, which must be called in the same goroutine as the test (SA2002)
raftgorums/integration_test.go:497:3: the goroutine calls T.FailNow, which must be called in the same goroutine as the test (SA2002)
raftgorums/raft.go:207:2: empty critical section (SA2001)
measure.go:114:3: the argument is already a string, there's no need to use fmt.Sprintf (S1025)
filestorage.go:16:2: var snapshotBucket is unused (U1000)
raftgorums/raft.go:64:2: field lookup is unused (U1000)
raftgorums/raft.go:65:2: field peers is unused (U1000)

Not sure if the SA2002 problems identified above is related to the deadlock reported in issue #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants