Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for kv v2 in databasesecretengineconfig #229

Open
raffaelespazzoli opened this issue Feb 2, 2024 · 1 comment
Open

add support for kv v2 in databasesecretengineconfig #229

raffaelespazzoli opened this issue Feb 2, 2024 · 1 comment

Comments

@raffaelespazzoli
Copy link
Collaborator

No description provided.

@yann-soubeyrand
Copy link

yann-soubeyrand commented Jan 22, 2025 •
edited
Loading

Hello, #255 seems to be related.

How do you see a possible fix? Do you think we should add a field IsKVv2 to the VaultSecretReference struct and adapt the behaviour accordingly in each type needing to read a secret? Or should we introduce an abstraction and use it instead of directly using vaultClient.Logical().Read() in each type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raffaelespazzoli @yann-soubeyrand