This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
switch to circle #58
Merged
switch to circle #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoyTechnology
suggested changes
Jan 22, 2017
butlerx
changed the title
VoyTechnology
previously requested changes
Jan 22, 2017
| @@ -0,0 +1,3 @@ | |||
| machine: | |||
| node: | |||
| version: 6.9.4 | |||
There was a problem hiding this comment.
Are we dropping support for older version of node or is this just temporary? I this case, can you add a TODO (if possible).
There was a problem hiding this comment.
What will happen to the Slack notifications?
There was a problem hiding this comment.
slack is handled by circle but not in this config
also all servers with node will be using lts so didnt see a reason to test btu could be added in future
VoyTechnology
approved these changes
Jan 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #57