Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

minimize html #54

Closed
butlerx opened this issue Oct 11, 2016 · 10 comments · Fixed by #61
Closed

minimize html #54

butlerx opened this issue Oct 11, 2016 · 10 comments · Fixed by #61

Comments

@butlerx
Copy link
Member

butlerx commented Oct 11, 2016

No description provided.

@butlerx
Copy link
Member Author

butlerx commented Oct 12, 2016

theres 3 index.html file one in the root dir and the others in 2015 and 2016 these are the files to be minimized and outputted to the dist file with their event.json in the same dir

@butlerx
Copy link
Member Author

butlerx commented Oct 12, 2016

theres also comments at the top of the page you'll need to remove

@shivamluthra
Copy link

@butlerx Hi sir,
i actually wanted to contribute to this repo and cloned it to my machine yesterday. I was having problems while setup process as the terminal showed me some errors while npm install command execution. Moreover, i wasn't able to run gulp command to run index.html file at localhost. Can you please guide me ?

@butlerx
Copy link
Member Author

butlerx commented Oct 12, 2016

what where your errors with the npm install
You might be having problems with your node path aswell that would be solved by installing gulp globally npm install -g gulp

@shivamluthra
Copy link

@butlerx i sorted it out . now it's working ! Can you assign me for this issue ? And what else is to be minimised in index.html apart from removing comments at top?
Thanks.

@butlerx
Copy link
Member Author

butlerx commented Oct 13, 2016

removing the whitespace and comments should be everything

i also cant assign you the issue as you arnt part of the repo or the organisation

@kartik95
Copy link

Is this issue resolved? @butlerx

@butlerx
Copy link
Member Author

butlerx commented Oct 14, 2016

this issue isnt resolved but @shivamluthra only said he was goign to work on it yesterday

@shivamluthra
Copy link

@butlerx I am done with the minification part. Just remind me again that do i have to place all three index.html files along with their event.json in dist directory only or let them be there in different folders only as it is there before?

@butlerx
Copy link
Member Author

butlerx commented Oct 16, 2016

put them in the dist directory with the event beside them but they need to keep their folder structure so you should have ./dist/index.html, ./dist/event.json, and ./dist/2015, ./dist/2016 with theire index and event.json in them

shivamluthra pushed a commit to shivamluthra/techweek.dcu.ie that referenced this issue Oct 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants