NarrowPublicClassMethodParamTypeRule: wrong error when method is called recusively

[scollovati]

Example

public function myMethod(string $Id, int $recursive_round = 1): ?array
{
    [...]

    return self::myMethod($Id, 2);
}

Error wrongly reported

Parameters should have "string" types as the only types passed to this method

The parameter should not be removed from the method signature.

[TheoD02]

Hi,

I'm encountering a similar issue, but in a different context. Here's the situation 😄

Method Definition

public function authenticate(string|false $code = false): ?string

Reported Error

Parameters should have "string|false" types as the only types passed to this method

In my project, I have only two calls to this method:

$accessToken = $this->service->oauth()->authenticate($code);
// and
$accessToken = $this->service->oauth()->authenticate();

Expected Behavior

I expect no error because false is the default value.

Temporary Solution

To resolve this issue for now, I am explicitly setting the default value to false:

$accessToken = $this->deezerClient->oauth()->authenticate(false);

[TomasVotruba]

Thanks for reporting 👍

Could you add a minimal test fixture test case into the tests? Similar to:
https://github.com/rectorphp/type-perfect/pull/54/files#diff-d59e8ba733575aff2100d3664c8b4cece68c519555707db21d2a43340bb11495

It will be easier and faster for me to fix it then 🤗 Thank you

[scollovati]

Thanks for reporting 👍

Could you add a minimal test fixture test case into the tests? Similar to: https://github.com/rectorphp/type-perfect/pull/54/files#diff-d59e8ba733575aff2100d3664c8b4cece68c519555707db21d2a43340bb11495

It will be easier and faster for me to fix it then 🤗 Thank you

I tried to create it here. Hope that it is what you expect: #57