[Nette] About migrating 51K lines of code to Laravel

[genesiscz]

Hello. I tried to create a discussion thread but couldn't because it is not enabled (or whatever).

I am in process of refactoring a big Nette project using no Doctrine (only NetteDatabase) (51k lines of code) and preparing it to be migrated to Laravel.

Many things were done by using generators (such as DB Entities), but many of these things will probably need help from Rector. I know I probably have to create a new set for that, and would love your help.

Are there any sets I can use as a whole, or at least point me to some specific Rector Rules that comes into your mind?

I know I will specifically need RenameClassRector, RenameMethodRector.

I for sure know I will need rule to transfer all parameters from action*, render*

• render(int $id, ?int $param1, ?string $param2, int $param3) -> render(Request $request)
• but then in the first line [$id, $param1, $param2, $param3] = $request->getParameters(["id", "param1", "param2", "param3"]
  If you had time to help me with this one, even in pseudocode/description, it would be really appreciated (and for sure donated if that saves me even 10 hours of my work)

[TomasVotruba]

Hi,

I've moved it here to discussion, as it's the place you wanted at first.

Congrats on a honorable challange! I think many project would benefit from such migration set.
I don't have any experience with Nette to Laravel. We did another migration, that is not the same, but will have very similar procedure. We migrated Nette to Symfony, you can read about it here:

• https://tomasvotruba.com/blog/2019/02/21/how-we-migrated-from-nette-to-symfony-in-3-weeks-part-1/
• https://tomasvotruba.com/blog/2019/03/07/why-we-migrated-from-nette-to-symfony-in-3-weeks-part-2/
• https://tomasvotruba.com/blog/2019/03/11/why-we-migrated-from-nette-to-symfony-in-3-weeks-part-3/

There is lot of generic knowledge about framework migrations, that would save your some blind branches.

The set can be found here: https://github.com/rectorphp/rector/blob/master/config/set/nette-to-symfony.php

Personally, I'd just take it and modify custom rules from Symfony to Laravel. They're very alike (Laravel build on Symfony ideology), so that would only syntax tweaks. Whole work could be matter of 1 week. Depends what mess is the Nette project in :)

If you want to speed-up learning process, I can offer you private consulting 👍

[genesiscz]

I am gonna dive in and consider if I need a private consulting. What is your hourly salary?

I was actually inspired by these articles to do this migration in the first place. It's pretty messy but is getting better. :-)

Another thing is that we're moving from templates into API (as we are going to use React for the whole thing). So everything we have thrown into the templates now has to be carefully moved out into JSON response without exposing too much.

Another question came into mind - what do you use to document REST API?

[TomasVotruba]

Depends on the project and time spent, around 90-120 €. Contact me on email for details.

It's pretty messy but is getting better. :-)

Yeah, first migration is the worst :) but second feel more like copy-pasting.

So migrating templates to json + React? That sounds cool. But, in my experience people can easily get stuck on doing many migrations at once. I recommend doing the framework first. Completely. Then doing anything else.

[TomasVotruba]

I'm curious, how is it going? :)

[genesiscz]

I am not sure how would the Repository docBlocks Rector help the general public.
The parameters extraction is more possible to be useful for somebody, but probably requires a little bit of manual tuning, too, which is, I guess, not welcome. I can post a PR of the second one, but after I actually apply the Rector without much errors.

[TomasVotruba]

The 1st and 2nd rule are generic for Nette and Laravel, so they would save time or next similar migrations.
I can polish the manual tuning to make them generic, don't worry about it.

[genesiscz]

What if the rule uses methods from Laravel Support package, such as $modelName = Str::singular($repositoryClass);?

[TomasVotruba]

If it's not pulling whole Laravel, it should be fine :)

If it is, we can use this package instead: https://symfony.com/blog/new-in-symfony-5-1-deprecated-the-inflector-component

[genesiscz]

Is it okay if it fails for some cases then?

dump(Str::singular("ApiDevices")); // -> ApiDevice
dump($inflector->singularize("ApiDevices")); -> ["ApiDevex", "ApiDevix", "ApiDevice"]

---

On another note, I've created a third Rule to add/remove null type to model properties which are nullable based on information_schema. How would you go with database query/connection right from the Rector Rule?

    ---------- begin diff ----------
--- Original
+++ New
@@ -7,15 +7,15 @@
 use Illuminate\Database\Eloquent\Relations\HasMany;
 /**
  * @property int $id
- * @property int $race_result_id
- * @property int $driver_id
- * @property int $race_id
+ * @property int|null $race_result_id
+ * @property int|null $driver_id
+ * @property int|null $race_id
  * @property int $position
  * @property int $best_lap_time
  * @property int $timestamp
- * @property Race $race
- * @property Driver $driver
- * @property RaceResult $raceResult
+ * @property Race|null $race
+ * @property Driver|null $driver
+ * @property RaceResult|null $raceResult
  * @property RaceResultDriverBadge[]|Collection $raceResultDriverBadges
  */
 class RaceResultDriver extends BaseModel
    ----------- end diff -----------

[genesiscz]

I am currently struggling with the function params into Request $request Rector rule.

	/**
	 * @param ClassMethod $classMethod
	 */
	private function migrateToFunction(ClassMethod $classMethod): ?ClassMethod
	{
		$args = [];

		/** @var Param $param */
		foreach ($classMethod->getParams() as $param) {
			// function actionTest(int $id, int $id2)
			$args[] = $this->getName($param);
		}

		// first line of function
		$first = $classMethod->getStmts()[0];
		if (!$first) {
			return null;
		}

		foreach($args as $var) {
			// $request->input('id');
			$methodCall = $this->createMethodCall(
				'request', "input", [
					$this->createArg($var)
				]
			);

			$assign = new Assign(new Variable($var), $methodCall);
			$this->addNodeBeforeNode($assign, $first);
		}

		$classMethod->params = [
			new Param(new Variable("request"), null, new FullyQualified(\App\Requests\Request::class))
		];

		return $classMethod;
	}

Any idea why would this remove lines between other statements inside of that method?

    ---------- begin diff ----------
--- Original
+++ New
@@ -72,22 +72,22 @@
                }
        }

-       function actionDefault($reservation_id): void
+       function actionDefault(\App\Requests\Request $request): void
        {
+               $reservation_id = $request->input('reservation_id');
                $this->redirect("hall", ["id" => 1]);
        }

-       function actionHall($id, $reservation_id): void
+       function actionHall(\App\Requests\Request $request): void
        {
+               $id = $request->input('id');
+               $reservation_id = $request->input('reservation_id');
                $this->template->hall = $hall = $this->getHall($id);
-
                $reservations_q = $this->hall_reservations->where("hall_id", $id);
                $reservations = [];
-
                foreach ($reservations_q as $reservation) {
                        $reservations[$reservation->hour][$reservation->minute] = $reservation;
                }
-
                $this->template->reservations = $reservations;
                $this->template->reservation_id = $reservation_id;
        }