Double Login Tests #6294
Merged
Double Login Tests #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I wanted to ensure the double login tests would pass for realm-react. * Everything works as they should and now we have a basic UserProvider test.
kraenhansen
reviewed
Dec 1, 2023
Comment on lines
103
to
108
| console.log("testing results: ", { | ||
| id, | ||
| currentId: realmApp?.currentUser?.id, | ||
| refreshToken, | ||
| currentRefreshToken: realmApp?.currentUser?.refreshToken, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| console.log("testing results: ", { | |
| id, | |
| currentId: realmApp?.currentUser?.id, | |
| refreshToken, | |
| currentRefreshToken: realmApp?.currentUser?.refreshToken, | |
| }); |
kraenhansen
reviewed
Dec 1, 2023
|
|
||
| useEffect(() => { | ||
| if (isUserRegistered && !result.pending && result.operation !== AuthOperationName.LogInWithEmailPassword) { | ||
| console.log("logging in user"); |
There was a problem hiding this comment.
Suggested change
| console.log("logging in user"); |
kraenhansen
reviewed
Dec 1, 2023
|
|
||
| useEffect(() => { | ||
| if (result.success && result.operation === AuthOperationName.Register) { | ||
| console.log("user registered"); |
There was a problem hiding this comment.
Suggested change
| console.log("user registered"); |
kraenhansen
reviewed
Dec 1, 2023
|
|
||
| useEffect(() => { | ||
| if (!isUserRegistered && !result.pending && result.operation !== AuthOperationName.Register) { | ||
| console.log("registering user"); |
There was a problem hiding this comment.
Suggested change
| console.log("registering user"); |
kraenhansen
approved these changes
Dec 1, 2023
elle-j
approved these changes
Dec 1, 2023
takameyer
force-pushed
the
andrew/double-login
branch
from
d3bf5c6 to
3c61eff
Compare
bimusiek
pushed a commit
to bimusiek/realm-js
that referenced
this pull request
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
To the reviewer
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary