Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify a prepack command for packages #6224

Closed
wants to merge 1 commit into from
Closed

Conversation

takameyer
Copy link
Contributor

What, How & Why?

Packages were using the bundle script for preparing for release. Sometimes it requires more than bundling to prepare a package. This unifies everything under prepack.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@takameyer takameyer marked this pull request as draft November 2, 2023 18:55
@takameyer
Copy link
Contributor Author

Putting this in draft, just want this here for later discussion

@kraenhansen
Copy link
Member

An alternative is to add another prepack script which declares a dependency on bundle but that shouldn't happen for the realm package as we bundle this in a separate job than we package (we could of course also revisit that decision).

@takameyer
Copy link
Contributor Author

Leaving as is for now.

@takameyer takameyer closed this Jan 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants