Additions to custom user data #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elle-j
commented
Oct 30, 2023
Comment on lines
+87
to
+91
| <View style={styles.status}> | ||
| <Text style={styles.statusText}> | ||
| Team: {user.customData.team} | ||
| </Text> | ||
| </View> |
There was a problem hiding this comment.
Nit: Just moved this above the "Connected" text.
But also, removed the ? after customData as it will always return a record.
elle-j
commented
Oct 30, 2023
There was a problem hiding this comment.
The changes here and some in StoreScreen.tsx (i.e. moving the responsibility of deleting the user to this file) are the same as in the previous PR. But since this one will be merged after, the previous changes probably would have been overwritten had it not been changed here as well.
takameyer
approved these changes
Oct 31, 2023
takameyer
pushed a commit
that referenced
this pull request
Oct 31, 2023
takameyer
pushed a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Some additions/updates to the custom user data addition to the example app:
onUserCreationcallback to be run as anApplication Authenticationin order to run in the context of the existing app user.☑️ ToDos
--