useUser fixes for Realm React
#6206
Conversation
takameyer
force-pushed
the
andrew/delete-user
branch
from
039cd2d to
5656140
Compare
| @@ -16,7 +16,7 @@ | |||
| }, | |||
| "wireit": { | |||
| "bundle": { | |||
| "command": "rollup --config", | |||
| "command": "rollup --config && tsc -p tsconfig.types.json", | |||
There was a problem hiding this comment.
Should this be a separate types command? Since technically this isn't bundling the types now.
There was a problem hiding this comment.
As our ci assumes a single command for preparing packages for release, I would be hesitant to put this in a separate command.
Otherwise, we can make a follow up PR which adds a types command to every package (or simply build, which contains bundle and types) and update our workflows to call this as well.
There was a problem hiding this comment.
@kraenhansen I put this in our next roundtable. I think you bring up a good point.
My suggestion is to create a script in each of our mono-repo packages called prepack, which can include whatever scripts it needs to prepare for being consumed by another project. This could include bundle, generateTypes, build, etc.
Then the CI workflows would be updated to run this command instead of bundle.
There was a problem hiding this comment.
It was the idea that these inter-package task dependencies should be configured via wireit. It's much more capable as it'll cache outputs and potentially execute tasks in parallel.
There was a problem hiding this comment.
I don't disagree, I just want to unify on a script that specifically deals with preparing for release.
* Used a different type declaration generation method which solved typing issues * Updated `UserProvider` to always update the user reference on user events * Updated connection example to include a delete user function to test this feature
Co-authored-by: LJ <[email protected]>
takameyer
force-pushed
the
andrew/delete-user
branch
from
792328c to
6f07e03
Compare
Co-authored-by: LJ <[email protected]>
What, How & Why?
UserProviderto always update the user reference on user eventsThis closes #6196 and #6186
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary