Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQF compliant queries in migration tests #7060

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

sean-brandenburg
Copy link
Contributor

@sean-brandenburg sean-brandenburg commented Oct 13, 2023

What, How & Why?

Device sync is enabling indexed queryable fields in PBS->QBS migrations which means that there are limitations on the types of queries that a QBS client is able to make after the migration (See Here)

This change fixes some non compliant queries in migration tests

realm_id = partition1 OR realm_id = partition2 -> realm_id = partition2
truepredicate -> realm_id = partition2

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@sean-brandenburg sean-brandenburg changed the title BAAS-21435: IQF compliant queries in migration tests IQF compliant queries in migration tests Oct 13, 2023
@coveralls-official
Copy link

coveralls-official bot commented Oct 13, 2023

Pull Request Test Coverage Report for Build sean.brandenburg_902

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 79 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.615%

Files with Coverage Reduction New Missed Lines %
test/object-store/sync/flx_migration.cpp 1 98.93%
src/realm/array_string.cpp 2 87.78%
src/realm/cluster.cpp 2 80.25%
src/realm/obj.cpp 2 91.36%
src/realm/object-store/sync/sync_manager.cpp 2 86.9%
src/realm/sync/network/websocket.cpp 2 75.46%
src/realm/sync/noinst/server/server.cpp 2 75.96%
src/realm/util/compression.cpp 2 91.31%
src/realm/sort_descriptor.cpp 3 93.7%
src/realm/sync/network/network.cpp 3 89.93%
Totals Coverage Status
Change from base Build 1756: 0.03%
Covered Lines: 230574
Relevant Lines: 251677

💛 - Coveralls

@sean-brandenburg sean-brandenburg marked this pull request as ready for review October 16, 2023 14:07
@michael-wb michael-wb self-requested a review October 16, 2023 15:00
Copy link
Contributor

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tkaye407 tkaye407 merged commit 3618b2e into realm:master Oct 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants