Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jinyoungchoi95] Exception handling 및 refactoring #43

Closed
3 tasks done
jinyoungchoi95 opened this issue Aug 30, 2021 · 0 comments
Closed
3 tasks done

[jinyoungchoi95] Exception handling 및 refactoring #43

jinyoungchoi95 opened this issue Aug 30, 2021 · 0 comments
Assignees
@jinyoungchoi95
Labels
feature ori 오리의 이슈

Comments

@jinyoungchoi95
Copy link
Member

jinyoungchoi95 commented Aug 30, 2021 •
edited
Loading

[AS-IS]

  • Exception handling 미적용
  • Exception message 미적용
  • vo 미적용

[TO-BE]

  • Exception 전체 handling 구현
  • vo 적용
  • 메소드 네이밍 리팩토링
@jinyoungchoi95 jinyoungchoi95 added feature ori 오리의 이슈 labels Aug 30, 2021
@jinyoungchoi95 jinyoungchoi95 self-assigned this Aug 30, 2021
@jinyoungchoi95 jinyoungchoi95 changed the title [jinyoungchoi95] Exception handling 및 GET /api/profiles/{username} API [jinyoungchoi95] Exception handling 및 refactoring Aug 31, 2021
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: 미사용 import 제거
7e1d466
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: 개행 컨벤션
bc381f3
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: getter 메소드 네임 변경
98d667e
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: getter 메소드 네임 변경
ed9dfff
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: service 내부 validation 제거
8fcabd5
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: Image vo 추가
37ac37d
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: Image vo 추가
f8882ac
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: Bio vo 추가
0b6631a
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: Bio vo 추가
f9e1255
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: ErrorCode 저장용 Enum 클래스 생성
a11a998
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: BusinessException 생성
e1f6c9c
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: BusinessException 수정 및 NotFoundException 추가
6be00ff
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: Duplicate Exception 생성 및 적용
579b17a
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: UserNotFoundException 생성 및 적용
13cc954
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: UserNotFoundException 생성 및 적용
f2528d4
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: UserNotFoundException 생성 및 적용
069d985
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: UserNotFoundException 생성 및 적용
9d02533
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: UserService BusinessException 전환
23414c9
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: 불필요 메소드 제거
2a29785
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: ErrorCode enum 클래스 생성
17b435e
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: user not found 메시지 수정
2a5980b
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: password Exception custom
981ed61
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: ErrorCode HttpStatus 변경
b3bb13a
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: ErrorCode username 적용
679a22f
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: ErrorCode email 적용
2600c17
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: ErrorCode password 적용
90bb8fe
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor
5b8e813
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor
f4a418a
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: 패키지 이동
d943794
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: Password 정적 팩토리 메소드 패턴 적용
96a80d8
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: Username 정적 팩토리 메소드 패턴 적용
a950847
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: Email 정적 팩토리 메소드 패턴 적용
cee09dc
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: 미사용 getter 제거 및 toValueObject 메소드 추가
4c8a4d6
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor
9d81f02
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor
4ee881d
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: Exception handling 구현
65176b2
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] test: JwtExceptionFilter 테스트 추가
5ca1c67
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor
74feb8b
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] feat: EntityPoint test 추가
4cf58b3
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: 미사용 메소드 제거
8628b24
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] test: ErrorResponse toJson 메소드 테스트
f93b4a6
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] test: JwtExceptionFilter success 테스트 추가
2ac67e6
@jinyoungchoi95 jinyoungchoi95 mentioned this issue Sep 8, 2021
Merged
jinyoungchoi95 added a commit that referenced this issue Sep 8, 2021
@jinyoungchoi95
[#43] refactor: null 반환 에러 수정
fa92cf8
jinyoungchoi95 added a commit that referenced this issue Sep 12, 2021
@jinyoungchoi95
[#43] refactor: constructor line refactor
1871afa
jinyoungchoi95 added a commit that referenced this issue Sep 12, 2021
@jinyoungchoi95
[#43] refactor: 미사용 logger 및 getClass적용
bf1cd7e
jinyoungchoi95 added a commit that referenced this issue Sep 13, 2021
@jinyoungchoi95
[#43] refactor: String content > MediaType 상수 변환
7d56007
jinyoungchoi95 added a commit that referenced this issue Sep 15, 2021
@jinyoungchoi95
[#43] refactor: 네이밍 이슈 수정
c5e9f64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinyoungchoi95 jinyoungchoi95

Labels
feature ori 오리의 이슈
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jinyoungchoi95