Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]: Please Support i18n for 18.react.dev #7399

Open
lumirlumir opened this issue Jan 1, 2025 · 3 comments
Open

[Suggestion]: Please Support i18n for 18.react.dev #7399

lumirlumir opened this issue Jan 1, 2025 · 3 comments

Comments

@lumirlumir
Copy link
Contributor

lumirlumir commented Jan 1, 2025

Summary

Hello,

I am currently the maintainer of ko.react.dev.

I noticed that the React Docs v18 was archived as 18.react.dev, but there is no support for i18n for translations of the v18 version of the React Docs.

I would like to suggest adding i18n support for translations, such as 18.ko.react.dev or something similar!

If it's not possible, would it be okay if I host v18 version of ko.react.dev myself for legacy users?

Page

https://ko.react.dev

@rammba
Copy link
Contributor

rammba commented Jan 3, 2025

Hello, I'm maintainer for Serbian language together with @lxmarinkovic. For now I don't think there is much difference between latest version (v19) and v18, but I suppose docs will be updated only for v19 from now on.
I think good idea is to leave v18 translated as well, especially when content is almost similar to the current version.

@lumirlumir
Copy link
Contributor Author

lumirlumir commented Jan 4, 2025

@rammba Thanks for sharing your thoughts!

However, I believe it would be better to maintain the React v18 version separately. Combining the contents of v18 and v19 could lead to confusion for users.

Many well-known open-source projects, such as facebook/docusaurus, manage their legacy versions separately. React also follows this approach with resources like 18.react.dev for older versions.

Alternatively, we could use a previous Vercel production link, such as https://ko-react-exy5xcwjj-fbopensource.vercel.app/. This link provides the past Korean translation of React v18 (you can find this link in the Deployment section on GitHub).

image


The main reason I created this issue is to request official support for this i18n feature from React!

Using links like https://ko-react-exy5xcwjj-fbopensource.vercel.app/ feels a bit messy and semantically improper.


Anyway, happy new year, and I truly appreciate your passion for React!

@rammba
Copy link
Contributor

rammba commented Jan 4, 2025

Yeah I totally agree with you. Even though there are vercel links provided by the bot, it would be great to have official domain for legacy versions. I hope maintainers will accept your proposal.

I wish you a great and productive new year! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants