Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ply abort when we git am --abort under the hood #19

Open
rconradharris opened this issue Jul 11, 2013 · 0 comments
Open

Ply abort when we git am --abort under the hood #19

rconradharris opened this issue Jul 11, 2013 · 0 comments
Labels

Comments

@rconradharris
Copy link
Owner

rick@nova-dev:~/Documents/code/openstack/nova$ ply abort
Traceback (most recent call last):
File "/home/rick/.virtualenvs/openstack/bin/ply", line 9, in
load_entry_point('plypatch==0.3.5', 'console_scripts', 'ply')()
File "/home/rick/Documents/code/openstack/ply/plypatch/cli.py", line 271, in main
args.func(args)
File "/home/rick/Documents/code/openstack/ply/plypatch/cli.py", line 69, in do
self.working_repo.abort()
File "/home/rick/Documents/code/openstack/ply/plypatch/init.py", line 249, in abort
self._resolve_conflict('abort')
File "/home/rick/Documents/code/openstack/ply/plypatch/init.py", line 236, in _resolve_conflict
self.am(**kwargs)
File "/home/rick/Documents/code/openstack/ply/plypatch/git/init.py", line 14, in wrapper
return fn(self, _args, *_kwargs)
File "/home/rick/Documents/code/openstack/ply/plypatch/git/init.py", line 73, in am
raise exc.PatchDidNotApplyCleanly
plypatch.git.exc.PatchDidNotApplyCleanly

If we manually resolved an am we stlil a way to ply resolve or ply abort.

Looks like am --abort returns an error (since there is nothing to abort) and this raises a PatchDidNotApplyCleanly exception. Solution is to catch that error and raise NothingToAbort, then have restore handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant